Issue 1345983007: dart2js CPS: Clean up the S-Expression builder.

Issue 1345983007: dart2js CPS: Clean up the S-Expression builder. (Closed)

Created:
5 years, 3 months ago by Kevin Millikin (Google)

Modified:
5 years, 3 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js CPS: Clean up the S-Expression builder. * Type annotations were not correct anymore, since we refactored type propagation. * Continuations were not decorated. This meant that they weren't marked with '**' when they caused an integrity violation. * There was a bug in the arity of calls to _currentIsolate that manifested when trying to build the argument list string. * Formatting needed some small cleanups. R=karlklose@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b97a6bc0c9c8bfc251494926b7969af19241e952

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removing inadvertent change to a constant. #

Patch Set 3 : Also print all the arguments for intercepted calls. #

Patch Set 4 : Also print all the arguments for intercepted calls. #

Patch Set 5 : Cleanup. #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -27 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart	View	1 2 3 4	5 chunks	+20 lines, -19 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/task.dart	View	1 3 4	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

https://codereview.chromium.org/1345983007/diff/1/pkg/compiler/lib/src/js_backend/codegen/task.dart File pkg/compiler/lib/src/js_backend/codegen/task.dart (right): https://codereview.chromium.org/1345983007/diff/1/pkg/compiler/lib/src/js_backend/codegen/task.dart#newcode129 pkg/compiler/lib/src/js_backend/codegen/task.dart:129: static const Pattern PRINT_TYPED_IR_FILTER = ''; I won't commit ...

5 years, 3 months ago (2015-09-18 09:00:58 UTC) #2

Kevin Millikin (Google)

5 years, 3 months ago (2015-09-18 09:31:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
b97a6bc0c9c8bfc251494926b7969af19241e952 (presubmit successful).

Expand Messages | Collapse Messages