Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1345943006: Report UNRESOLVED_INSTANCE_MEMBER_REFERENCE for dynamicVar.member references. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report UNRESOLVED_INSTANCE_MEMBER_REFERENCE for dynamicVar.member references. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/75600fc162d48a5848ca20c2d7f22c3beddc4581

Patch Set 1 #

Patch Set 2 : more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 1 3 chunks +42 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test2.dart View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-17 16:08:00 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-17 16:39:33 UTC) #2
scheglov
5 years, 3 months ago (2015-09-17 17:37:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
75600fc162d48a5848ca20c2d7f22c3beddc4581 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698