Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1345413004: Omit extra argument to createElement/NS if null (Closed)

Created:
5 years, 3 months ago by Alan Knight
Modified:
5 years, 3 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Omit extra argument to createElement/NS if null BUG= Committed: https://github.com/dart-lang/sdk/commit/0568fa86793769f6042807a5d3e29bd392b78556

Patch Set 1 #

Patch Set 2 : Remove test suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -14 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +21 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/html.status View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 3 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
TBR
5 years, 3 months ago (2015-09-21 23:56:57 UTC) #2
Alan Knight
Committed patchset #2 (id:20001) manually as 0568fa86793769f6042807a5d3e29bd392b78556 (presubmit successful).
5 years, 3 months ago (2015-09-22 16:28:42 UTC) #3
terry
5 years, 3 months ago (2015-09-22 16:38:16 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698