Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1345403002: Do not emit semicolons for await expressions in ToSourceVisitor (Closed)

Created:
5 years, 3 months ago by Harry Terkelsen
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not emit semicolons for await expressions in ToSourceVisitor Closes #24364 BUG= R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f4426b109ba98149b622bc61293217f0b0ee6a1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Harry Terkelsen
5 years, 3 months ago (2015-09-17 00:42:50 UTC) #2
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-17 16:54:57 UTC) #3
scheglov
LGTM
5 years, 3 months ago (2015-09-17 16:55:45 UTC) #4
Harry Terkelsen
5 years, 3 months ago (2015-09-17 18:20:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f4426b109ba98149b622bc61293217f0b0ee6a1c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698