Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 134533007: New analyzer snapshot. (Closed)

Created:
6 years, 11 months ago by scheglov
Modified:
6 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New analyzer snapshot. Mostly to remove unnecessary casts. But also includes your latest changed for Alan. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1855 lines, -1195 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 7 chunks +155 lines, -2 lines 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/options.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 27 chunks +158 lines, -94 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 70 chunks +190 lines, -97 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 32 chunks +232 lines, -89 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 38 chunks +74 lines, -74 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 13 chunks +116 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/instrumentation.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 98 chunks +205 lines, -205 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 316 chunks +594 lines, -519 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 12 chunks +44 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 11 chunks +19 lines, -19 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 3 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 11 months ago (2014-01-10 22:15:17 UTC) #1
Brian Wilkerson
LGTM! Thanks!
6 years, 11 months ago (2014-01-10 22:20:06 UTC) #2
scheglov
6 years, 11 months ago (2014-01-10 22:28:09 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r31717 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698