Read files in chunks, not relaying on size.

Read files in chunks, not relaying on size.

Allows for reading of /proc inputs on linux/mac.

BUG=https://code.google.com/p/dart/issues/detail?id=9572,https://code.google.com/p/dart/issues/detail?id=401

Committed: https://code.google.com/p/dart/source/detail?r=20768

[Anders Johnsen, 2013-04-02 07:28:38]

Any suggestions for how we should test this? Just a non-windows test, reading
'new File('/proc/self/status').readAsStringSync();' and testing for length > 0?

[Mads Ager (google), 2013-04-02 07:46:14]

LGTM

Adding a Linux/Mac only test sounds like a good idea.

[Søren Gjesse, 2013-04-02 07:46:29]

LGTM

Regarding testing, /proc is only available on Linux, but testing reading
something in there should be fine. Maybe one of the tests we have using stdin
could be done using /dev/fd/0 as well on Linux and Mac OS.

[Anders Johnsen, 2013-04-02 09:51:35]

PTAL

[Mads Ager (google), 2013-04-02 10:20:20]

lgtm

https://codereview.chromium.org/13453002/diff/5001/tests/standalone/io/file_r...
File tests/standalone/io/file_read_special_device_test.dart (right):

https://codereview.chromium.org/13453002/diff/5001/tests/standalone/io/file_r...
tests/standalone/io/file_read_special_device_test.dart:9: var dir = new
Path(options.script).directoryPath.toString();
You don't need the toString here since you are using it in string-interpolation
below.

[Søren Gjesse, 2013-04-02 10:24:55]

lgtm

[Anders Johnsen, 2013-04-02 10:39:02]

Ty, landing!

https://codereview.chromium.org/13453002/diff/5001/tests/standalone/io/file_r...
File tests/standalone/io/file_read_special_device_test.dart (right):

https://codereview.chromium.org/13453002/diff/5001/tests/standalone/io/file_r...
tests/standalone/io/file_read_special_device_test.dart:9: var dir = new
Path(options.script).directoryPath.toString();
On 2013/04/02 10:20:20, Mads Ager wrote:
> You don't need the toString here since you are using it in
string-interpolation
> below.

Done.

[Anders Johnsen, 2013-04-02 10:40:12]

Committed patchset #3 manually as r20768 (presubmit successful).