Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1345273002: Weaken an assert in the message handler (Closed)

Created:
5 years, 3 months ago by zra
Modified:
5 years, 3 months ago
Reviewers:
turnidge, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Weaken an assert in the message handler and remove an assert in windows thread joining. TBR BUG= Committed: https://github.com/dart-lang/sdk/commit/1390b664cbc1674fb828dc772431fa7957c4f5e9

Patch Set 1 #

Patch Set 2 : remove assert weakening #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M runtime/vm/os_thread_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
5 years, 3 months ago (2015-09-16 19:27:25 UTC) #2
zra
Committed patchset #2 (id:20001) manually as 1390b664cbc1674fb828dc772431fa7957c4f5e9 (presubmit successful).
5 years, 3 months ago (2015-09-16 21:12:12 UTC) #3
Ivan Posva
5 years, 3 months ago (2015-09-16 22:25:28 UTC) #4
Message was sent while issue was closed. 
LGTM

Thanks,
-Ivan

Powered by Google App Engine
This is Rietveld 408576698