Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1345083002: Revert "Dartium JS Interop enabled." (Closed)

Created:
5 years, 3 months ago by terry
Modified:
5 years, 3 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Dartium JS Interop enabled." This reverts commit 403bd1698dd41320eaa5767d5ba2af40b062074a. TBR=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/09c804aa78e610eb44cc35e6f3d1ae8e6d1edbc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3646 lines, -13456 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 520 chunks +678 lines, -684 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1395 chunks +1556 lines, -7613 lines 0 comments Download
M sdk/lib/html/html_common/filtered_element_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 24 chunks +43 lines, -206 lines 0 comments Download
M sdk/lib/internal/list.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 13 chunks +16 lines, -51 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 14 chunks +9 lines, -18 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 251 chunks +231 lines, -2138 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 55 chunks +39 lines, -407 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 49 chunks +21 lines, -567 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 12 chunks +16 lines, -107 lines 0 comments Download
M tests/co19/co19-analyzer.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +0 lines, -23 lines 0 comments Download
M tests/co19/co19-dart2js.status View 24 chunks +24 lines, -6 lines 0 comments Download
M tests/co19/co19-dartium.status View 18 chunks +31 lines, -7 lines 0 comments Download
M tests/html/fontface_loaded_test.dart View 2 chunks +8 lines, -15 lines 0 comments Download
M tests/html/html.status View 3 chunks +16 lines, -1 line 0 comments Download
M tests/html/messageevent_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/worker_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/analyzer/analyze_library.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 3 chunks +3 lines, -4 lines 0 comments Download
M tools/dom/scripts/css_code_generator.py View 5 chunks +21 lines, -3 lines 0 comments Download
M tools/dom/scripts/generator.py View 4 chunks +16 lines, -81 lines 0 comments Download
M tools/dom/scripts/go.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 9 chunks +7 lines, -76 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 5 chunks +0 lines, -6 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 10 chunks +76 lines, -47 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 11 chunks +26 lines, -32 lines 0 comments Download
M tools/dom/src/CssRectangle.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M tools/dom/src/Html5NodeValidator.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/src/NodeValidatorBuilder.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/dom/src/Validators.dart View 4 chunks +8 lines, -5 lines 0 comments Download
M tools/dom/src/WrappedList.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/_chrome/app_runtime.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/src/_chrome/app_window.dart View 11 chunks +25 lines, -25 lines 0 comments Download
M tools/dom/src/_chrome/file_system.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M tools/dom/src/_chrome/utils.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/dom/src/dart2js_DOMImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/dartium_KeyEvent.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/dom/src/dartium_WrappedEvent.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 4 chunks +11 lines, -9 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 5 chunks +46 lines, -170 lines 0 comments Download
M tools/dom/templates/html/dartium/indexed_db_dartium.darttemplate View 2 chunks +1 line, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/svg_dartium.darttemplate View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/dom/templates/html/dartium/web_audio_dartium.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_gl_dartium.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_sql_dartium.darttemplate View 2 chunks +0 lines, -7 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Blob.darttemplate View 1 chunk +0 lines, -17 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 435 chunks +540 lines, -522 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_DOMException.darttemplate View 1 chunk +0 lines, -44 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 2 chunks +14 lines, -43 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 3 chunks +7 lines, -2 lines 0 comments Download
D tools/dom/templates/html/impl/impl_DocumentType.darttemplate View 1 chunk +0 lines, -16 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 29 chunks +50 lines, -80 lines 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_FileReader.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
D tools/dom/templates/html/impl/impl_HTMLAudioElement.darttemplate View 1 chunk +0 lines, -20 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 5 chunks +4 lines, -105 lines 0 comments Download
D tools/dom/templates/html/impl/impl_HTMLFrameSetElement.darttemplate View 1 chunk +0 lines, -21 lines 0 comments Download
M tools/dom/templates/html/impl/impl_MutationObserver.darttemplate View 1 chunk +8 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 6 chunks +34 lines, -9 lines 0 comments Download
D tools/dom/templates/html/impl/impl_SVGCursorElement.darttemplate View 1 chunk +0 lines, -19 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 3 chunks +2 lines, -18 lines 0 comments Download
D tools/dom/templates/html/impl/impl_SVGFEDropShadowElement.darttemplate View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/dom/templates/html/impl/impl_SVGGlyphRefElement.darttemplate View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/dom/templates/html/impl/impl_SVGMPathElement.darttemplate View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/dom/templates/html/impl/impl_ServiceWorker.darttemplate View 1 chunk +0 lines, -15 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Touch.darttemplate View 1 chunk +8 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WheelEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 2 chunks +3 lines, -3 lines 0 comments Download
D tools/dom/templates/html/impl/impl_WorkerLocation.darttemplate View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/dom/templates/html/impl/impl_WorkerNavigator.darttemplate View 1 chunk +0 lines, -23 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 1 chunk +0 lines, -29 lines 0 comments Download
M tools/dom/templates/immutable_list_mixin.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
terry
5 years, 3 months ago (2015-09-16 02:44:50 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
09c804aa78e610eb44cc35e6f3d1ae8e6d1edbc9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698