Write the contents of ICData and ObjectPools more eagerly and the contents of Code and Functions

Write the contents of ICData and ObjectPools more eagerly and the contents of Code and Functions less eagerly.

Fix read/write mismatch in ClosureData.

Fixes precompiled dart2js benchmarks.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/6732c05f6e911b8bfcdd6cf0e88889ad3592abce

[rmacnak, 2015-09-22 00:04:46]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[Florian Schneider, 2015-09-23 12:23:39]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2015-09-23 12:23:39]

lgtm

https://codereview.chromium.org/1345053003/diff/10003/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (left):

https://codereview.chromium.org/1345053003/diff/10003/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:1732: SnapshotWriterVisitor visitor(writer);
I think it would be safer to get rid of the default value for
SnapshotWriterVisitor::as_references_. It would be easier to check if it matches
the reading part. i.e. without having to remember that the default is true (aka
kAsReference).

https://codereview.chromium.org/1345053003/diff/10003/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1345053003/diff/10003/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:2125: SnapshotWriterVisitor visitor(writer,
false);
s/false/kInlinedObject/

[rmacnak, 2015-09-23 18:12:04]

Also added comment and todo to WriteObjectImpl per discussion with Siva.

https://codereview.chromium.org/1345053003/diff/10003/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (left):

https://codereview.chromium.org/1345053003/diff/10003/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:1732: SnapshotWriterVisitor visitor(writer);
On 2015/09/23 12:23:39, Florian Schneider wrote:
> I think it would be safer to get rid of the default value for
> SnapshotWriterVisitor::as_references_. It would be easier to check if it
matches
> the reading part. i.e. without having to remember that the default is true
(aka
> kAsReference).

Done.

https://codereview.chromium.org/1345053003/diff/10003/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1345053003/diff/10003/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:2125: SnapshotWriterVisitor visitor(writer,
false);
On 2015/09/23 12:23:39, Florian Schneider wrote:
> s/false/kInlinedObject/

Done.

[rmacnak, 2015-09-23 18:12:20]

Committed patchset #4 (id:50001) manually as
6732c05f6e911b8bfcdd6cf0e88889ad3592abce (presubmit successful).