Issue 1344733003: dart2js: Register helpers for updating send to type variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1344733003: dart2js: Register helpers for updating send to type variable. (Closed)

Created:
5 years, 3 months ago by karlklose

Modified:
5 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: Register helpers for updating send to type variable. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/4ce8a23f0a03ec385acfb5793a596edb2eb92f31

Patch Set 1 #

Total comments: 2

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -18 lines)			Patch
M	pkg/compiler/lib/src/common/backend_api.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/common/resolution.dart	View	2 chunks	+3 lines, -4 lines	1 comment	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/members.dart	View	2 chunks	+5 lines, -2 lines	1 comment	Download
M	pkg/compiler/lib/src/resolution/registry.dart	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/1344733003/diff/1/pkg/compiler/lib/src/common/resolution.dart File pkg/compiler/lib/src/common/resolution.dart (right): https://codereview.chromium.org/1344733003/diff/1/pkg/compiler/lib/src/common/resolution.dart#newcode11 pkg/compiler/lib/src/common/resolution.dart:11: import '../elements/elements.dart' show AstElement, ErroneousElement, TypeVariableElement; Long line. ...

5 years, 3 months ago (2015-09-15 13:23:40 UTC) #2

karlklose

5 years, 3 months ago (2015-09-15 13:31:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4ce8a23f0a03ec385acfb5793a596edb2eb92f31 (presubmit successful).

Expand Messages | Collapse Messages