Removing all Worker-related APIs

Removing all Worker-related APIs

Need to revisit these once WebWorkers and Isolates are worked out.

BUG=8932

[blois, 2013-04-05 01:43:04]

I believe that this is the full list.

[vsm, 2013-04-05 15:54:52]

https://codereview.chromium.org/13444007/diff/2001/sdk/lib/svg/dart2js/svg_da...
File sdk/lib/svg/dart2js/svg_dart2js.dart (left):

https://codereview.chromium.org/13444007/diff/2001/sdk/lib/svg/dart2js/svg_da...
sdk/lib/svg/dart2js/svg_dart2js.dart:7688: static const int SVG_SPREADMETHOD_PAD
= 1;
Are these SVG changes intended?  And related to Workers?

https://codereview.chromium.org/13444007/diff/2001/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/13444007/diff/2001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:496: # 'any set
DedicatedWorkerContext.postMessage': _serialize_SSV, # Workers
The commented code here and below is pretty ugly.  Do you want to just delete? 
Alternatively, a TODO comment to re-enable worker functionality at some point.

[Emily Fortuna, 2013-04-05 16:21:08]

https://codereview.chromium.org/13444007/diff/2001/sdk/lib/web_sql/dart2js/we...
File sdk/lib/web_sql/dart2js/web_sql_dart2js.dart (right):

https://codereview.chromium.org/13444007/diff/2001/sdk/lib/web_sql/dart2js/we...
sdk/lib/web_sql/dart2js/web_sql_dart2js.dart:73: typedef void
_SQLTransactionSyncCallback(_SQLTransactionSync transaction);
why not delete these types instead of making them private?

https://codereview.chromium.org/13444007/diff/2001/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/13444007/diff/2001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:496: # 'any set
DedicatedWorkerContext.postMessage': _serialize_SSV, # Workers
On 2013/04/05 15:54:53, vsm wrote:
> The commented code here and below is pretty ugly.  Do you want to just delete?

> Alternatively, a TODO comment to re-enable worker functionality at some point.

Yeah, I'd be inclined to delete as well. That's what version control is for! We
can add a comment saying there was functionality for that though so people know
where to look in the history.

[blois, 2013-04-05 16:43:09]

https://codereview.chromium.org/13444007/diff/2001/sdk/lib/svg/dart2js/svg_da...
File sdk/lib/svg/dart2js/svg_dart2js.dart (left):

https://codereview.chromium.org/13444007/diff/2001/sdk/lib/svg/dart2js/svg_da...
sdk/lib/svg/dart2js/svg_dart2js.dart:7688: static const int SVG_SPREADMETHOD_PAD
= 1;
On 2013/04/05 15:54:53, vsm wrote:
> Are these SVG changes intended?  And related to Workers?

We have a list of types which are removed and the intention is that we remove
all members from the types, but we had a bug where some members were coming
through.

I fixed that bug in this CL, so the removed types are empty.

https://codereview.chromium.org/13444007/diff/2001/sdk/lib/web_sql/dart2js/we...
File sdk/lib/web_sql/dart2js/web_sql_dart2js.dart (right):

https://codereview.chromium.org/13444007/diff/2001/sdk/lib/web_sql/dart2js/we...
sdk/lib/web_sql/dart2js/web_sql_dart2js.dart:73: typedef void
_SQLTransactionSyncCallback(_SQLTransactionSync transaction);
On 2013/04/05 16:21:08, Emily Fortuna wrote:
> why not delete these types instead of making them private?

Typedefs were treated as all other interfaces- renamed rather than removed. It
shouldn't really cause an issue because it should be ignored, but I've updated
it to special-case templates regardless.

https://codereview.chromium.org/13444007/diff/2001/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/13444007/diff/2001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:496: # 'any set
DedicatedWorkerContext.postMessage': _serialize_SSV, # Workers
On 2013/04/05 16:21:08, Emily Fortuna wrote:
> On 2013/04/05 15:54:53, vsm wrote:
> > The commented code here and below is pretty ugly.  Do you want to just
delete?
> 
> > Alternatively, a TODO comment to re-enable worker functionality at some
point.
> 
> Yeah, I'd be inclined to delete as well. That's what version control is for!
We
> can add a comment saying there was functionality for that though so people
know
> where to look in the history.

Removed.

[Emily Fortuna, 2013-04-05 16:47:58]

lgtm

https://codereview.chromium.org/13444007/diff/2001/sdk/lib/web_sql/dart2js/we...
File sdk/lib/web_sql/dart2js/web_sql_dart2js.dart (right):

https://codereview.chromium.org/13444007/diff/2001/sdk/lib/web_sql/dart2js/we...
sdk/lib/web_sql/dart2js/web_sql_dart2js.dart:73: typedef void
_SQLTransactionSyncCallback(_SQLTransactionSync transaction);
On 2013/04/05 16:43:09, blois wrote:
> On 2013/04/05 16:21:08, Emily Fortuna wrote:
> > why not delete these types instead of making them private?
> 
> Typedefs were treated as all other interfaces- renamed rather than removed. It
> shouldn't really cause an issue because it should be ignored, but I've updated
> it to special-case templates regardless.

Yeah, this way we reduce the library size (very slightly, but hey!).

[vsm, 2013-04-05 17:10:58]

LGTM.

We might consider removing some of these types entirely if there is no way they
can appear on the UI thread.  But - just had a quick chat with sra - the current
code size impact of an empty class is minimal (should be a single entry in a
table).

[blois, 2013-04-05 20:44:15]

Re-added Worker and AbstractWorker, with test & supported checks.

[Emily Fortuna, 2013-04-05 22:03:41]

https://codereview.chromium.org/13444007/diff/6002/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_WorkerContext.darttemplate (left):

https://codereview.chromium.org/13444007/diff/6002/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_WorkerContext.darttemplate:37:
Future<FileSystem> requestFileSystem(int size, {bool persistent: false}) {
why not leave these nicer APIs in here if we're still exposing WorkerContext?

[blois, 2013-04-05 22:14:48]

https://codereview.chromium.org/13444007/diff/6002/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_WorkerContext.darttemplate (left):

https://codereview.chromium.org/13444007/diff/6002/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_WorkerContext.darttemplate:37:
Future<FileSystem> requestFileSystem(int size, {bool persistent: false}) {
On 2013/04/05 22:03:41, Emily Fortuna wrote:
> why not leave these nicer APIs in here if we're still exposing WorkerContext?

WorkerContext becomes a 'deleted class', so all members are removed. These
cleanup APIs just forward to the _requestFileSystem members which have been
deleted.

The indexedDB API above is technically 'OK', but it seems the better change is
just to delete this file entirely.

[Emily Fortuna, 2013-04-05 22:20:27]

lgtm