Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1344173005: dart2js CPS: Small cleanup of the compilation pipeline. (Closed)

Created:
5 years, 3 months ago by Kevin Millikin (Google)
Modified:
5 years, 3 months ago
Reviewers:
asgerf, karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js CPS: Small cleanup of the compilation pipeline. Apply all the optimization passes uniformly. Rename CpsIR to CpsIr and TreeIR to TreeIr. R=asgerf@google.com, karlklose@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/19d7f93dadc86616d07dcae04ce0dfaa640c96ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -51 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 6 chunks +42 lines, -46 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Google)
5 years, 3 months ago (2015-09-18 11:36:29 UTC) #1
asgerf
LGTM
5 years, 3 months ago (2015-09-18 11:37:56 UTC) #2
karlklose
LGTM.
5 years, 3 months ago (2015-09-18 11:54:02 UTC) #3
Kevin Millikin (Google)
5 years, 3 months ago (2015-09-18 12:13:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
19d7f93dadc86616d07dcae04ce0dfaa640c96ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698