Issue 1343783002: dart2js ssa: Avoid tracking too much in load elimination

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1343783002: dart2js ssa: Avoid tracking too much in load elimination (Closed)

Created:
5 years, 3 months ago by sra1

Modified:
5 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js ssa: Avoid tracking too much in load elimination R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/f9459ad4acda717e13230d6241ac865d7e0f9eb2

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -11 lines)			Patch
M	pkg/compiler/lib/src/ssa/builder.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/nodes.dart	View		4 chunks	+8 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/optimize.dart	View	1	1 chunk	+46 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

LGTM. add test to make sure the CPS doesn't run into the same problem. https://codereview.chromium.org/1343783002/diff/1/pkg/compiler/lib/src/ssa/optimize.dart ...

5 years, 3 months ago (2015-09-14 16:08:19 UTC) #2

sra1

Committed patchset #2 (id:20001) manually as f9459ad4acda717e13230d6241ac865d7e0f9eb2 (presubmit successful).

5 years, 3 months ago (2015-09-14 19:50:08 UTC) #3

sra1

5 years, 3 months ago (2015-09-14 23:09:46 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1343783002/diff/1/pkg/compiler/lib/src/ssa/op...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/1343783002/diff/1/pkg/compiler/lib/src/ssa/op...
pkg/compiler/lib/src/ssa/optimize.dart:2001: // actually kill it's input, but we
don't make use that elsewhere so
On 2015/09/14 16:08:19, floitsch wrote:
> of that

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages