Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1343393004: SDK gyp: support Xcode V7 (Closed)

Created:
5 years, 3 months ago by kevmoo
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : cl feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gyp/find_mac_gcc_version.py View 1 2 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 9 (3 generated)
kevmoo
5 years, 3 months ago (2015-09-18 22:29:53 UTC) #2
kevmoo
Adding Bill
5 years, 3 months ago (2015-09-22 12:11:26 UTC) #4
Bill Hesse
lgtm https://codereview.chromium.org/1343393004/diff/20001/tools/gyp/find_mac_gcc_version.py File tools/gyp/find_mac_gcc_version.py (right): https://codereview.chromium.org/1343393004/diff/20001/tools/gyp/find_mac_gcc_version.py#newcode28 tools/gyp/find_mac_gcc_version.py:28: elif (major == 4 and minor >= 5) ...
5 years, 3 months ago (2015-09-22 12:13:35 UTC) #5
kevmoo
https://codereview.chromium.org/1343393004/diff/20001/tools/gyp/find_mac_gcc_version.py File tools/gyp/find_mac_gcc_version.py (right): https://codereview.chromium.org/1343393004/diff/20001/tools/gyp/find_mac_gcc_version.py#newcode28 tools/gyp/find_mac_gcc_version.py:28: elif (major == 4 and minor >= 5) or ...
5 years, 3 months ago (2015-09-22 12:21:07 UTC) #6
kevmoo
Committed patchset #3 (id:40001) manually as 6012e9070dc010c1b0a7a1fa08453234262f892d (presubmit successful).
5 years, 3 months ago (2015-09-22 12:21:26 UTC) #7
Paul Berry
5 years, 3 months ago (2015-09-22 12:38:48 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1343393004/diff/40001/tools/gyp/find_mac_gcc_...
File tools/gyp/find_mac_gcc_version.py (right):

https://codereview.chromium.org/1343393004/diff/40001/tools/gyp/find_mac_gcc_...
tools/gyp/find_mac_gcc_version.py:28: elif (major == 4 and minor >= 5) or major
=> 5:
This is a syntax error.  I think you mean ">=" instead of "=>".

Powered by Google App Engine
This is Rietveld 408576698