Issue 1343253002: - Remove unused Counters class from isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1343253002: - Remove unused Counters class from isolate. (Closed)

Created:
5 years, 3 months ago by Ivan Posva

Modified:
5 years, 3 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

- Remove unused Counters class from isolate. BUG= R=koda@google.com Committed: https://github.com/dart-lang/sdk/commit/f5bd38f1adca50ce5da9eca2071c9c9ae0e870f5

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -98 lines)			Patch
D	runtime/vm/counters.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	runtime/vm/counters.cc	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	runtime/vm/isolate.h	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

It was being used for quick debugging and stats collection during development, but now TimeLine ...

5 years, 3 months ago (2015-09-16 15:10:36 UTC) #3

Ivan Posva

Committed patchset #1 (id:1) manually as f5bd38f1adca50ce5da9eca2071c9c9ae0e870f5 (presubmit successful).

5 years, 3 months ago (2015-09-16 15:15:14 UTC) #4

Ivan Posva

5 years, 3 months ago (2015-09-16 22:24:48 UTC) #5

Message was sent while issue was closed.

On 2015/09/16 15:10:36, koda wrote:
> It was being used for quick debugging and stats collection during development,
> but now TimeLine should be able to provide such functionality.
> 
> LGTM

I understand that it was useful during debugging and development, but this had
to be balanced with the 1024 words added on a per isolate basis.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages