Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 1343033002: Use cammelCase for all service extension variables (Closed)

Created:
5 years, 3 months ago by ricow1
Modified:
5 years, 3 months ago
Reviewers:
Cutch, johnmmccutchan
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -115 lines) Patch
M runtime/observatory/tests/service/file_service_test.dart View 1 chunk +12 lines, -12 lines 0 comments Download
M runtime/observatory/tests/service/process_service_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/tcp_socket_closing_service_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/tcp_socket_service_test.dart View 4 chunks +57 lines, -57 lines 0 comments Download
M runtime/observatory/tests/service/udp_socket_service_test.dart View 1 chunk +20 lines, -20 lines 0 comments Download
M sdk/lib/io/io_resource_info.dart View 3 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ricow1
5 years, 3 months ago (2015-09-15 06:29:35 UTC) #1
Cutch
lgtm
5 years, 3 months ago (2015-09-15 16:48:59 UTC) #3
ricow1
5 years, 3 months ago (2015-09-16 05:27:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6e48e9617d849f8d1f623bd06801cea8b5d59d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698