Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1342933006: Rename ReceiverMask and ReceiverMaskSet and update comments. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename ReceiverMask and ReceiverMaskSet and update comments. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/573c1c68e4ebc8508b81830246d6c6955528e9bb

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix after rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -72 lines) Patch
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 7 chunks +82 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 3 months ago (2015-09-15 10:36:01 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 3 months ago (2015-09-16 22:29:20 UTC) #3
Johnni Winther
5 years, 3 months ago (2015-09-17 08:41:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
573c1c68e4ebc8508b81830246d6c6955528e9bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698