Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1342903002: Fixes for the new task model (Closed)

Created:
5 years, 3 months ago by Brian Wilkerson
Modified:
5 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, Leaf
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -43 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +46 lines, -42 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +65 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
The partial resolver was skipping too many function bodies. This cleans up the logic so ...
5 years, 3 months ago (2015-09-14 20:08:58 UTC) #2
scheglov
LGTM
5 years, 3 months ago (2015-09-14 20:13:51 UTC) #3
Brian Wilkerson
5 years, 3 months ago (2015-09-14 20:16:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
004839fc868a1479790297fd34f8c16e8f69426e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698