Issue 134263007: Only allow “assets” to appear in the root of a URL.

Issue 134263007: Only allow “assets” to appear in the root of a URL. (Closed)

Created:
6 years, 10 months ago by Bob Nystrom

Modified:
6 years, 10 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Only allow “assets” to appear in the root of a URL. BUG=https://code.google.com/p/dart/issues/detail?id=16646 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=32663

Patch Set 1 #

Total comments: 3

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -25 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback.dart	View	1 chunk	+35 lines, -19 lines	3 comments	Download
M	sdk/lib/_internal/pub/test/serve/serve_from_app_asset_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/serve_from_dependency_asset_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/134263007/diff/1/sdk/lib/_internal/pub/lib/src/barback.dart File sdk/lib/_internal/pub/lib/src/barback.dart (right): https://codereview.chromium.org/134263007/diff/1/sdk/lib/_internal/pub/lib/src/barback.dart#newcode133 sdk/lib/_internal/pub/lib/src/barback.dart:133: /// as the top-level directory. (It throws a ...

6 years, 10 months ago (2014-02-12 22:27:07 UTC) #2

Bob Nystrom

Committed patchset #1 manually as r32663 (presubmit successful).

6 years, 10 months ago (2014-02-13 18:03:39 UTC) #3

Bob Nystrom

6 years, 10 months ago (2014-02-13 18:03:59 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/134263007/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback.dart (right):

https://codereview.chromium.org/134263007/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback.dart:133: /// as the top-level directory.
(It throws a FormatException if "assets"
On 2014/02/12 22:27:07, nweiz wrote:
> "It" -> "This", "FormatException" -> "[FormatException]"

Done.

https://codereview.chromium.org/134263007/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback.dart:133: /// as the top-level directory.
(It throws a FormatException if "assets"
On 2014/02/12 22:27:07, nweiz wrote:
> "It" -> "This", "FormatException" -> "[FormatException]"

Done.

Expand Messages | Collapse Messages