Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1342293003: specify when a Future completes for IOSink's addStream (Closed)

Created:
5 years, 3 months ago by sethladd
Modified:
5 years, 3 months ago
CC:
jamesr1, reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

specify when a Future completes for IOSink's addStream BUG= R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/55fc80e15e43059618201f429605ae84411d9edb

Patch Set 1 #

Total comments: 2

Patch Set 2 : tweaks from review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sdk/lib/io/io_sink.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sethladd
Tweak to API docs after feedback from user.
5 years, 3 months ago (2015-09-18 19:51:49 UTC) #2
jamesr
This is very helpful, thank you.
5 years, 3 months ago (2015-09-18 19:54:27 UTC) #3
Lasse Reichstein Nielsen
LGTM with comment. https://codereview.chromium.org/1342293003/diff/1/sdk/lib/io/io_sink.dart File sdk/lib/io/io_sink.dart (right): https://codereview.chromium.org/1342293003/diff/1/sdk/lib/io/io_sink.dart#newcode99 sdk/lib/io/io_sink.dart:99: * Returns a [Future] that completes ...
5 years, 3 months ago (2015-09-21 09:50:47 UTC) #4
Lasse Reichstein Nielsen
LGTM with comment.
5 years, 3 months ago (2015-09-21 09:50:48 UTC) #5
sethladd
https://codereview.chromium.org/1342293003/diff/1/sdk/lib/io/io_sink.dart File sdk/lib/io/io_sink.dart (right): https://codereview.chromium.org/1342293003/diff/1/sdk/lib/io/io_sink.dart#newcode99 sdk/lib/io/io_sink.dart:99: * Returns a [Future] that completes when On 2015/09/21 ...
5 years, 3 months ago (2015-09-21 09:56:21 UTC) #6
sethladd
5 years, 3 months ago (2015-09-21 09:57:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
55fc80e15e43059618201f429605ae84411d9edb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698