Add optional message to assert in Dart2js - continued

Add optional message to assert in Dart2js - continued

This CL takes https://chromiumcodereview.appspot.com/1325843003/ and makes some changes:

 - distinguish enableUserAssertions from enableTypeAssertions
 - better type inference for disabled assertions

R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/d5b2b393f3d2b3fe99c5ac1d1d9493b11a5eec8e

Committed: https://github.com/dart-lang/sdk/commit/0b9e80edbfed607b0ee4c2c9f58b62772457b804
(with --assert-message flag)

[sra1, 2015-09-15 23:30:54]

Patchset #2 (id:20001) has been deleted

[sra1, 2015-09-15 23:31:00]

Patchset #2 (id:40001) has been deleted

[sra1, 2015-09-15 23:39:18]

sra@google.com changed reviewers:
+ johnniwinther@google.com, lrn@google.com, sigmund@google.com

[sra1, 2015-09-15 23:46:39]

Patchset #2 (id:60001) has been deleted

[Lasse Reichstein Nielsen, 2015-09-16 06:00:57]

lgtm

https://codereview.chromium.org/1342213003/diff/100001/pkg/compiler/lib/src/s...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1342213003/diff/100001/pkg/compiler/lib/src/s...
pkg/compiler/lib/src/ssa/builder.dart:2614: if (!node.hasMessage) {
Document that this does
  assertHelper(condition);
like below? (or is the code obvious? :)

[Lasse Reichstein Nielsen, 2015-09-16 06:03:52]

There should also be an "--assert-message" flag necessary to enable this feature
(according to issue 24216).
I started on the in https://codereview.chromium.org/1312613006/ but weren't able
to find a way to pass the flag down to the parser.

[Johnni Winther, 2015-09-16 16:48:39]

https://codereview.chromium.org/1342213003/diff/100001/pkg/compiler/lib/src/r...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1342213003/diff/100001/pkg/compiler/lib/src/r...
pkg/compiler/lib/src/resolution/members.dart:507: visit(node.message);
The fastest way is the add an option like in
https://codereview.chromium.org/1346943003 and then check here that
[node.message] is `null` if the feature is not enabled.

[sra1, 2015-09-16 17:33:30]

https://codereview.chromium.org/1342213003/diff/100001/pkg/compiler/lib/src/r...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1342213003/diff/100001/pkg/compiler/lib/src/r...
pkg/compiler/lib/src/resolution/members.dart:507: visit(node.message);
On 2015/09/16 16:48:38, Johnni Winther wrote:
> The fastest way is the add an option like in
> https://codereview.chromium.org/1346943003 and then check here that
> [node.message] is `null` if the feature is not enabled.

I will do this under a separate CL.
A separate CL will help with removing the flag.

[Siggi Cherem (dart-lang), 2015-09-16 19:10:29]

On 2015/09/16 17:33:30, sra1 wrote:
>
https://codereview.chromium.org/1342213003/diff/100001/pkg/compiler/lib/src/r...
> File pkg/compiler/lib/src/resolution/members.dart (right):
> 
>
https://codereview.chromium.org/1342213003/diff/100001/pkg/compiler/lib/src/r...
> pkg/compiler/lib/src/resolution/members.dart:507: visit(node.message);
> On 2015/09/16 16:48:38, Johnni Winther wrote:
> > The fastest way is the add an option like in
> > https://codereview.chromium.org/1346943003 and then check here that
> > [node.message] is `null` if the feature is not enabled.
> 
> I will do this under a separate CL.
> A separate CL will help with removing the flag.

good idea. FWIW here is the CL where we removed the flag for null-aware
operators, which also needed the flag while parsing:

 
https://github.com/dart-lang/sdk/commit/5d2b0b07f56c81c0f7c328ab1d36501cb0223f36

You may be able to revert & rename the flag, but it's possible that the recent
refactoring we did on the scanner directory might confuse git-revert.

[sra1, 2015-09-16 22:16:14]

Committed patchset #4 (id:120001) manually as
d5b2b393f3d2b3fe99c5ac1d1d9493b11a5eec8e (presubmit successful).

[sra1, 2015-09-16 23:47:53]

Committed patchset #6 (id:160001) manually as
0b9e80edbfed607b0ee4c2c9f58b62772457b804 (presubmit successful).

[sra1, 2015-09-17 03:47:54]

https://codereview.chromium.org/1342213003/diff/100001/pkg/compiler/lib/src/s...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1342213003/diff/100001/pkg/compiler/lib/src/s...
pkg/compiler/lib/src/ssa/builder.dart:2614: if (!node.hasMessage) {
On 2015/09/16 06:00:56, Lasse Reichstein Nielsen wrote:
> Document that this does
>   assertHelper(condition);
> like below? (or is the code obvious? :)

Done.