Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 13421002: Changed pkg option to package-root. (Closed)

Created:
7 years, 8 months ago by Andrei Mouravski
Modified:
7 years, 8 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Changed pkg option to package-root. pkg will remain in a deprecated state for the time being. Committed: https://code.google.com/p/dart/source/detail?r=20808

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M sdk/lib/_internal/dartdoc/bin/dartdoc.dart View 1 2 3 5 chunks +20 lines, -10 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M utils/apidoc/apidoc.dart View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Andrei Mouravski
7 years, 8 months ago (2013-04-02 01:01:20 UTC) #1
Jacob
https://codereview.chromium.org/13421002/diff/5001/sdk/lib/_internal/dartdoc/bin/dartdoc.dart File sdk/lib/_internal/dartdoc/bin/dartdoc.dart (right): https://codereview.chromium.org/13421002/diff/5001/sdk/lib/_internal/dartdoc/bin/dartdoc.dart#newcode173 sdk/lib/_internal/dartdoc/bin/dartdoc.dart:173: // TODO(amouravski): This method is deprecated. Remove after 2 ...
7 years, 8 months ago (2013-04-02 01:03:41 UTC) #2
Andrei Mouravski
PTAL. https://codereview.chromium.org/13421002/diff/5001/sdk/lib/_internal/dartdoc/bin/dartdoc.dart File sdk/lib/_internal/dartdoc/bin/dartdoc.dart (right): https://codereview.chromium.org/13421002/diff/5001/sdk/lib/_internal/dartdoc/bin/dartdoc.dart#newcode173 sdk/lib/_internal/dartdoc/bin/dartdoc.dart:173: // TODO(amouravski): This method is deprecated. Remove after ...
7 years, 8 months ago (2013-04-02 01:05:47 UTC) #3
Jacob
lgtm
7 years, 8 months ago (2013-04-02 03:14:34 UTC) #4
Andrei Mouravski
7 years, 8 months ago (2013-04-02 19:32:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r20808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698