Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1341933002: Improve stack traces for error responses. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/json_rpc_2.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve stack traces for error responses. This tracks the stack chain when the request is made and uses it if the response fails. R=rnystrom@google.com Committed: https://github.com/dart-lang/json_rpc_2/commit/8ec8098f0fe79c3d800c5f655851728fd4fb5d81

Patch Set 1 #

Patch Set 2 : changelog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/client.dart View 4 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 3 months ago (2015-09-14 22:14:11 UTC) #1
Bob Nystrom
lgtm
5 years, 3 months ago (2015-09-14 23:08:53 UTC) #2
nweiz
5 years, 3 months ago (2015-09-15 00:28:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8ec8098f0fe79c3d800c5f655851728fd4fb5d81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698