Issue 13417002: Mark scheduled_server_test as flaky and increase the timeout on the other scheduled tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13417002: Mark scheduled_server_test as flaky and increase the timeout on the other scheduled tests. (Closed)

Created:
7 years, 8 months ago by nweiz

Modified:
7 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark scheduled_server_test as flaky and increase the timeout on the other scheduled tests. BUG=9582 Committed: https://code.google.com/p/dart/source/detail?r=20764

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -5 lines)			Patch
M	pkg/pkg.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/test/descriptor_test.dart	View	1 chunk	+3 lines, -2 lines	2 comments	Download
M	pkg/scheduled_test/test/scheduled_test_test.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. https://codereview.chromium.org/13417002/diff/1/pkg/scheduled_test/test/descriptor_test.dart File pkg/scheduled_test/test/descriptor_test.dart (right): https://codereview.chromium.org/13417002/diff/1/pkg/scheduled_test/test/descriptor_test.dart#newcode23 pkg/scheduled_test/test/descriptor_test.dart:23: // running pumpEventQueue, so we're increasing the timeout ...

7 years, 8 months ago (2013-04-02 00:45:22 UTC) #2

nweiz

Committed patchset #1 manually as r20764 (presubmit successful).

7 years, 8 months ago (2013-04-02 00:49:54 UTC) #3

nweiz

7 years, 8 months ago (2013-04-02 00:49:59 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/13417002/diff/1/pkg/scheduled_test/test/descr...
File pkg/scheduled_test/test/descriptor_test.dart (right):

https://codereview.chromium.org/13417002/diff/1/pkg/scheduled_test/test/descr...
pkg/scheduled_test/test/descriptor_test.dart:23: // running pumpEventQueue, so
we're increasing the timeout across the board.
On 2013/04/02 00:45:22, Bob Nystrom wrote:
> Mention the bug number here.

Done.

Expand Messages | Collapse Messages