Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1341623002: Add missing arity check for native entry in arm64 and mips simulators. (Closed)

Created:
5 years, 3 months ago by rmacnak
Modified:
5 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing arity check for native entry in arm64 and mips simulators. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/0ab5bc2942dc176dbe06453d247ed824a38f8a75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/vm/native_entry.cc View 4 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 3 months ago (2015-09-12 22:12:20 UTC) #2
Florian Schneider
lgtm
5 years, 3 months ago (2015-09-13 18:40:54 UTC) #3
rmacnak
5 years, 3 months ago (2015-09-14 19:09:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ab5bc2942dc176dbe06453d247ed824a38f8a75 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698