Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1341473002: Fix a variety of service protocol bugs. (Closed)

Created:
5 years, 3 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a variety of service protocol bugs. Add documentation for breakpoint. Fix Instance.pattern documentation. Fix Instance.bytes documentation. Add class field for null instances. Fix documentation of Context and closureContext. Make getObject return Collected for deleted breakpoints. Closes #24247 Closes #24249 Closes #24309 Closes #24325 Closes #24326 Closes #24327 BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b0ca0789be616560c77315ecca290ebcb0735606

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -81 lines) Patch
M runtime/lib/isolate_patch.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/debugger.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/json_test.cc View 2 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object_test.cc View 17 chunks +38 lines, -69 lines 0 comments Download
M runtime/vm/service.cc View 1 2 4 chunks +20 lines, -4 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 8 chunks +27 lines, -6 lines 0 comments Download
M runtime/vm/unit_test.h View 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/vm/unit_test.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 3 months ago (2015-09-11 18:05:08 UTC) #2
Cutch
LGTM with one issue https://codereview.chromium.org/1341473002/diff/20001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/1341473002/diff/20001/runtime/vm/service.cc#newcode1460 runtime/vm/service.cc:1460: *result = ObjectIdRing::kCollected; We've been ...
5 years, 3 months ago (2015-09-11 19:22:19 UTC) #3
turnidge
5 years, 3 months ago (2015-09-11 19:29:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b0ca0789be616560c77315ecca290ebcb0735606 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698