Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1341343002: Remove unused setter from ServerStarter and un-deprecate a used setter (Closed)

Created:
5 years, 3 months ago by Brian Wilkerson
Modified:
5 years, 3 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused setter from ServerStarter and un-deprecate a used setter R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b233ab26ad36093e209207445d54cfc62f6ece25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -32 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +3 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +1 line, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 4 chunks +0 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/starter.dart View 3 chunks +0 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 3 months ago (2015-09-15 16:04:54 UTC) #2
scheglov
LGTM
5 years, 3 months ago (2015-09-15 16:05:52 UTC) #3
Paul Berry
lgtm
5 years, 3 months ago (2015-09-15 16:14:45 UTC) #4
Brian Wilkerson
5 years, 3 months ago (2015-09-15 16:39:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b233ab26ad36093e209207445d54cfc62f6ece25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698