Issue 1341253002: Fix try (again!)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1341253002: Fix try (again!) (Closed)

Created:
5 years, 3 months ago by Johnni Winther

Modified:
5 years, 3 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix try (again!) BUG= Committed: https://github.com/dart-lang/sdk/commit/a158723177e387b3b36f919e547d899adb22dd8f

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	site/try/poi/scope_information_visitor.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/compiler/dart2js/serialization_test.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

TBR https://codereview.chromium.org/1341253002/diff/1/tests/compiler/dart2js/serialization_test.dart File tests/compiler/dart2js/serialization_test.dart (right): https://codereview.chromium.org/1341253002/diff/1/tests/compiler/dart2js/serialization_test.dart#newcode471 tests/compiler/dart2js/serialization_test.dart:471: check(element1, element2, 'libraryName', Just found this search for ...

5 years, 3 months ago (2015-09-15 08:28:31 UTC) #2

Johnni Winther

Committed patchset #1 (id:1) manually as a158723177e387b3b36f919e547d899adb22dd8f (presubmit successful).

5 years, 3 months ago (2015-09-15 08:29:01 UTC) #3

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages