Handle wrong method invocation of a type parameter (fix issue 13134).

Handle wrong method invocation of a type parameter (fix issue 13134).
Add test.

R=gbracha@google.com, hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31944

[gbracha, 2014-01-17 20:50:46]

https://codereview.chromium.org/134083005/diff/40001/tests/language/type_vari...
File tests/language/type_variable_conflict2_test.dart (right):

https://codereview.chromium.org/134083005/diff/40001/tests/language/type_vari...
tests/language/type_variable_conflict2_test.dart:11: Expect.equals(const
Symbol('T'), im.memberName);
It is more idiomatic to write

Expect.equals(#T, im.memberName);

https://codereview.chromium.org/134083005/diff/40001/tests/language/type_vari...
tests/language/type_variable_conflict2_test.dart:17: static bar() => T();  ///
02: static type warning
I think this should be compile time error because T() is equivalent to this.T().
This remains true in a static method, because T is in scope (even though it is a
malformed type).

[regis, 2014-01-18 00:12:19]

PTAL

https://codereview.chromium.org/134083005/diff/40001/tests/language/type_vari...
File tests/language/type_variable_conflict2_test.dart (right):

https://codereview.chromium.org/134083005/diff/40001/tests/language/type_vari...
tests/language/type_variable_conflict2_test.dart:11: Expect.equals(const
Symbol('T'), im.memberName);
On 2014/01/17 20:50:46, gbracha wrote:
> It is more idiomatic to write
> 
> Expect.equals(#T, im.memberName);

Done.

https://codereview.chromium.org/134083005/diff/40001/tests/language/type_vari...
tests/language/type_variable_conflict2_test.dart:17: static bar() => T();  ///
02: static type warning
On 2014/01/17 20:50:46, gbracha wrote:
> I think this should be compile time error because T() is equivalent to
this.T().
> This remains true in a static method, because T is in scope (even though it is
a
> malformed type).

Done.

[hausner, 2014-01-18 00:29:55]

LGTM with comment.

https://codereview.chromium.org/134083005/diff/110001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/134083005/diff/110001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:8436: ErrorMsg(primary_pos,
I think you can factor this out. It is an error with all selectors: T.id, T[]
and T(), T

As discussed offline, you are missing the T.id case.

https://codereview.chromium.org/134083005/diff/110001/tests/language/type_var...
File tests/language/type_variable_conflict2_test.dart (right):

https://codereview.chromium.org/134083005/diff/110001/tests/language/type_var...
tests/language/type_variable_conflict2_test.dart:25: static qux() => C.T();  ///
04: static type warning
You are missing the case T.notInScope;

[gbracha, 2014-01-18 00:33:59]

tests lgtm

[regis, 2014-01-18 00:48:53]

Thanks!

https://codereview.chromium.org/134083005/diff/110001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/134083005/diff/110001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:8436: ErrorMsg(primary_pos,
On 2014/01/18 00:29:55, hausner wrote:
> I think you can factor this out. It is an error with all selectors: T.id, T[]
> and T(), T
> 
> As discussed offline, you are missing the T.id case.

I added the check for T.id, but I did not factor out the code.

https://codereview.chromium.org/134083005/diff/110001/tests/language/type_var...
File tests/language/type_variable_conflict2_test.dart (right):

https://codereview.chromium.org/134083005/diff/110001/tests/language/type_var...
tests/language/type_variable_conflict2_test.dart:25: static qux() => C.T();  ///
04: static type warning
On 2014/01/18 00:29:55, hausner wrote:
> You are missing the case T.notInScope;

Done.

[regis, 2014-01-18 01:03:28]

Committed patchset #5 manually as r31944 (presubmit successful).