Issue 13408008: Use correct compilation unit for inlined field initializers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13408008: Use correct compilation unit for inlined field initializers. (Closed)

Created:
7 years, 8 months ago by Johnni Winther

Modified:
7 years, 8 months ago

Reviewers:
ahe, ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use correct compilation unit for inlined field initializers. BUG=http://dartbug.com/9602 Committed: https://code.google.com/p/dart/source/detail?r=20851

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -0 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1 chunk	+2 lines, -0 lines	1 comment	Download
A	tests/language/inline_super_field_lib.dart	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A	tests/language/inline_super_field_test.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

Committed patchset #1 manually as r20851 (presubmit successful).

7 years, 8 months ago (2013-04-03 12:17:22 UTC) #3

ngeoffray

7 years, 8 months ago (2013-04-07 09:12:02 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/13408008/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/13408008/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1338:
sourceElementStack.add(member);
Please use inlinedFrom instead, that does exactly that.

Expand Messages | Collapse Messages