Issue 1340423005: Blind attempt to fix test crash on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1340423005: Blind attempt to fix test crash on Windows (Closed)

Created:
5 years, 3 months ago by hausner

Modified:
5 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Blind attempt to fix test crash on Windows Not sure what causes the crash. Move compiler stats output to an earlier phase in Isolate shutdown, which is a good idea anyway. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a87da65c1357ce25f371b774bd2b4119c81c190b

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	runtime/vm/isolate.cc	View		2 chunks	+7 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

hausner

5 years, 3 months ago (2015-09-16 22:14:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a87da65c1357ce25f371b774bd2b4119c81c190b (presubmit successful).