Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340143003: Ignore underscores in the middle of words. (Closed)

Created:
5 years, 3 months ago by Bob Nystrom
Modified:
5 years, 3 months ago
Reviewers:
nweiz, sethladd
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/markdown.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ignore underscores in the middle of words. Fix #41. R=sethladd@google.com Committed: 4aaadf3d940bb172e1f6285af4d2b1710d309982

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 2 comments Download
M lib/src/inline_parser.dart View 1 chunk +2 lines, -4 lines 2 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/original/emphasis_and_strong.unit View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Bob Nystrom
5 years, 3 months ago (2015-09-14 21:10:40 UTC) #2
sethladd
very cool, thanks! (note to us/self: update pub.dartlang.org when this lands)
5 years, 3 months ago (2015-09-14 21:11:55 UTC) #3
sethladd
by the power invested in me: LGTM
5 years, 3 months ago (2015-09-14 21:22:07 UTC) #4
Bob Nystrom
Committed patchset #1 (id:1) manually as 4aaadf3d940bb172e1f6285af4d2b1710d309982 (presubmit successful).
5 years, 3 months ago (2015-09-14 21:23:27 UTC) #5
nweiz
https://codereview.chromium.org/1340143003/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1340143003/diff/1/CHANGELOG.md#newcode7 CHANGELOG.md:7: * Ignore underscores inside words (#41). If you're going ...
5 years, 3 months ago (2015-09-14 21:52:13 UTC) #6
Bob Nystrom
5 years, 3 months ago (2015-09-15 00:19:16 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1340143003/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1340143003/diff/1/CHANGELOG.md#newcode7
CHANGELOG.md:7: * Ignore underscores inside words (#41).
On 2015/09/14 21:52:13, nweiz wrote:
> If you're going to reference the issue, it would be nice to link to it.

I've never bothered doing that since I figure people can figure it out and it
makes the CHANGELOG easier to read as text to leave it out.

https://codereview.chromium.org/1340143003/diff/1/lib/src/inline_parser.dart
File lib/src/inline_parser.dart (right):

https://codereview.chromium.org/1340143003/diff/1/lib/src/inline_parser.dart#...
lib/src/inline_parser.dart:46: new TagSyntax(r'\b__', tag: 'strong', end:
r'__\b'),
On 2015/09/14 21:52:13, nweiz wrote:
> Using \b here isn't very non-English-friendly; it'll only take ASCII
> alphanumeric characters into account
> (http://www.ecma-international.org/ecma-262/5.1/#sec-15.10.2.6), so something
> like á_ḇ_č will still get formatted wrong.

Hmm, good point. I think this is sort of a stopgap solution until a more
comprehensive implementation that follows the full CommonMark spec can be done.

Powered by Google App Engine
This is Rietveld 408576698