Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340073002: Fix static analysis warnings in Observatory (Closed)

Created:
5 years, 3 months ago by Cutch
Modified:
5 years, 3 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix static analysis warnings in Observatory - Type check SourceLocation and UnresolvedSourceLocation. - Return null explicitly. - Remove unused import. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/fad876aa307f53941e4346031b45b32d0974ac78

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/observatory/tests/ui/inspector.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Cutch
5 years, 3 months ago (2015-09-14 17:26:15 UTC) #2
turnidge
https://codereview.chromium.org/1340073002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (left): https://codereview.chromium.org/1340073002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart#oldcode133 runtime/observatory/lib/src/elements/script_inset.dart:133: } bpt.location can have two types: SourceLocation and UnresolvedSourceLocation. ...
5 years, 3 months ago (2015-09-15 16:01:04 UTC) #3
Cutch
PTAL https://codereview.chromium.org/1340073002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (left): https://codereview.chromium.org/1340073002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart#oldcode133 runtime/observatory/lib/src/elements/script_inset.dart:133: } On 2015/09/15 16:01:03, turnidge wrote: > bpt.location ...
5 years, 3 months ago (2015-09-15 17:29:57 UTC) #4
turnidge
https://codereview.chromium.org/1340073002/diff/20001/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/1340073002/diff/20001/runtime/observatory/lib/src/elements/script_inset.dart#newcode129 runtime/observatory/lib/src/elements/script_inset.dart:129: } else if (location is UnresolvedSourceLocation) { UnresolvedSourceLocation can ...
5 years, 3 months ago (2015-09-15 17:58:24 UTC) #5
Cutch
https://codereview.chromium.org/1340073002/diff/20001/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/1340073002/diff/20001/runtime/observatory/lib/src/elements/script_inset.dart#newcode129 runtime/observatory/lib/src/elements/script_inset.dart:129: } else if (location is UnresolvedSourceLocation) { On 2015/09/15 ...
5 years, 3 months ago (2015-09-15 19:45:28 UTC) #6
turnidge
lgtm
5 years, 3 months ago (2015-09-15 19:46:53 UTC) #7
Cutch
5 years, 3 months ago (2015-09-15 19:57:46 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
fad876aa307f53941e4346031b45b32d0974ac78 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698