Issue 133993009: pkg/http: fixed analyzer warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133993009: pkg/http: fixed analyzer warnings (Closed)

Created:
6 years, 11 months ago by kevmoo

Modified:
6 years, 11 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/http: fixed analyzer warnings R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=31726

Patch Set 2 : nits #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -14 lines)			Patch
M	pkg/http/lib/src/base_request.dart	View	1	5 chunks	+7 lines, -6 lines	0 comments	Download
M	pkg/http/lib/src/utils.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/http/test/safe_http_server.dart	View		5 chunks	+12 lines, -1 line	0 comments	Download
M	pkg/pkg.status	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

One change, otherwise LGTM. https://codereview.chromium.org/133993009/diff/1/pkg/http/lib/src/base_request.dart File pkg/http/lib/src/base_request.dart (right): https://codereview.chromium.org/133993009/diff/1/pkg/http/lib/src/base_request.dart#newcode126 pkg/http/lib/src/base_request.dart:126: void _baseCheckFinalized() { Add a ...

6 years, 11 months ago (2014-01-11 00:02:44 UTC) #2

kevmoo

6 years, 11 months ago (2014-01-11 01:57:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31726 (presubmit successful).

Expand Messages | Collapse Messages

Issue 133993009: pkg/http: fixed analyzer warnings (Closed)

Description

Patch Set 1 #

Patch Set 2 : nits #

Messages