Issue 1339713002: Add LookupHeapObjectMessage and hook into LookupHeapObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1339713002: Add LookupHeapObjectMessage and hook into LookupHeapObject (Closed)

Created:
5 years, 3 months ago by Cutch

Modified:
5 years, 3 months ago

Reviewers:
turnidge, nweiz

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add LookupHeapObjectMessage and hook into LookupHeapObject - This makes isolate messages behave like other instances over the service protocol. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/fdf79d85a2d24384a807a9c39de291d42ab70ef7

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -40 lines)			Patch
	M	runtime/vm/service.cc	View		4 chunks	+25 lines, -37 lines	0 comments	Download
	M	runtime/vm/service/service.md	View	1 2	2 chunks	+20 lines, -3 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #3 (id:30001) manually as fdf79d85a2d24384a807a9c39de291d42ab70ef7 (presubmit successful).

5 years, 3 months ago (2015-09-11 17:22:46 UTC) #4

nweiz

5 years, 3 months ago (2015-09-11 19:34:13 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/1339713002/diff/30001/runtime/vm/service/serv...
File runtime/vm/service/service.md (right):

https://codereview.chromium.org/1339713002/diff/30001/runtime/vm/service/serv...
runtime/vm/service/service.md:1743: // RPCs, for example, getObject or evaluate.
DBC: Mention that this will always be the ID for an Instance.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages