Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1339363002: Reapply "Move megamorphic cache table into the Dart heap." (Closed)

Created:
5 years, 3 months ago by rmacnak
Modified:
5 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Move megamorphic cache table into the Dart heap." Prevent megamorphic miss function from losing its code: - Only include megamorphic function in precompiled snapshots. - Also put the megamorphic miss code in the object store. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/491b1d42f84184995b22e10c2367b8fafda08491

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -104 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.h View 2 chunks +13 lines, -24 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.cc View 1 2 2 chunks +38 lines, -46 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/object_store.h View 1 2 2 chunks +23 lines, -1 line 0 comments Download
M runtime/vm/object_store.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 3 months ago (2015-09-15 17:48:45 UTC) #2
siva
LGTM with one comment. https://codereview.chromium.org/1339363002/diff/20001/runtime/vm/megamorphic_cache_table.cc File runtime/vm/megamorphic_cache_table.cc (right): https://codereview.chromium.org/1339363002/diff/20001/runtime/vm/megamorphic_cache_table.cc#newcode78 runtime/vm/megamorphic_cache_table.cc:78: isolate->object_store()->set_megamorphic_miss_function(function); Maybe this should be ...
5 years, 3 months ago (2015-09-15 18:09:20 UTC) #3
rmacnak
https://codereview.chromium.org/1339363002/diff/20001/runtime/vm/megamorphic_cache_table.cc File runtime/vm/megamorphic_cache_table.cc (right): https://codereview.chromium.org/1339363002/diff/20001/runtime/vm/megamorphic_cache_table.cc#newcode78 runtime/vm/megamorphic_cache_table.cc:78: isolate->object_store()->set_megamorphic_miss_function(function); On 2015/09/15 18:09:20, siva wrote: > Maybe this ...
5 years, 3 months ago (2015-09-15 18:18:25 UTC) #4
rmacnak
5 years, 3 months ago (2015-09-15 18:18:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
491b1d42f84184995b22e10c2367b8fafda08491 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698