Improve Json constructor.

Improve Json constructor.

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32502

[Lasse Reichstein Nielsen, 2014-02-10 07:08:30]

lgtm

https://codereview.chromium.org/133923004/diff/1/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/133923004/diff/1/sdk/lib/convert/json.dart#ne...
sdk/lib/convert/json.dart:79: * integer list index for a list property, the map
string for object
map string -> string map key

https://codereview.chromium.org/133923004/diff/1/sdk/lib/convert/json.dart#ne...
sdk/lib/convert/json.dart:82: * If [reviver] is omitted, it defaults to
returning the value.
... it defaults to a function returning its argument.
or
... it defaults to the identity function.

https://codereview.chromium.org/133923004/diff/1/sdk/lib/convert/json.dart#ne...
sdk/lib/convert/json.dart:90: * If [toEncodable] is omitted, it defaults to
calling `.toJson()` on the
... it defaults to a function that returns the result of calling `.toJson()` on
the unencodable object
or
... the default behavior is to call `.toJson()` on the unencodable object and
return the result.

https://codereview.chromium.org/133923004/diff/1/sdk/lib/convert/json.dart#ne...
sdk/lib/convert/json.dart:143: }
Insert newline.

[floitsch, 2014-02-10 15:11:30]

https://codereview.chromium.org/133923004/diff/1/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/133923004/diff/1/sdk/lib/convert/json.dart#ne...
sdk/lib/convert/json.dart:79: * integer list index for a list property, the map
string for object
On 2014/02/10 07:08:30, Lasse Reichstein Nielsen wrote:
> map string -> string map key

Done.

https://codereview.chromium.org/133923004/diff/1/sdk/lib/convert/json.dart#ne...
sdk/lib/convert/json.dart:82: * If [reviver] is omitted, it defaults to
returning the value.
On 2014/02/10 07:08:30, Lasse Reichstein Nielsen wrote:
> ... it defaults to a function returning its argument.
> or
> ... it defaults to the identity function.

it defaults to returning the value argument. (since there are two).

https://codereview.chromium.org/133923004/diff/1/sdk/lib/convert/json.dart#ne...
sdk/lib/convert/json.dart:90: * If [toEncodable] is omitted, it defaults to
calling `.toJson()` on the
On 2014/02/10 07:08:30, Lasse Reichstein Nielsen wrote:
> ... it defaults to a function that returns the result of calling `.toJson()`
on
> the unencodable object
> or
> ... the default behavior is to call `.toJson()` on the unencodable object and
> return the result.

Done.

https://codereview.chromium.org/133923004/diff/1/sdk/lib/convert/json.dart#ne...
sdk/lib/convert/json.dart:143: }
On 2014/02/10 07:08:30, Lasse Reichstein Nielsen wrote:
> Insert newline.

Done.

[floitsch, 2014-02-10 15:51:39]

Committed patchset #2 manually as r32502 (presubmit successful).