Add GYP build rule for Try Dart!

Add GYP build rule for Try Dart!

R=kasperl@google.com, kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31828

[kasperl, 2014-01-14 15:37:33]

LGTM.

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/app.yaml
File dart/site/try/app.yaml (right):

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/app.yaml#n...
dart/site/try/app.yaml:21: # Soluion: Ignore its advice about "Leverage browser
caching".
Soluion -> Solution.

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/build_try.gyp
File dart/site/try/build_try.gyp (right):

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/build_try....
dart/site/try/build_try.gyp:1: # Copyright (c) 2013, the Dart project authors. 
Please see the AUTHORS file
2014

[kustermann, 2014-01-15 01:24:23]

lgtm

https://codereview.chromium.org/133893008/diff/60001/dart/dart.gyp
File dart/dart.gyp (right):

https://codereview.chromium.org/133893008/diff/60001/dart/dart.gyp#newcode188
dart/dart.gyp:188: 'target_name': 'try',
The name 'try' doesn't say much. Maybe we could rename that to 'try_dart' ?

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/app.yaml
File dart/site/try/app.yaml (right):

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/app.yaml#n...
dart/site/try/app.yaml:9: version: 7
I think you should change "version: 7" to "version: CHANGEME" to make it clear,
that someone should change the version before using "appcfg.py" to upload a new
app. See, e.g. [0]: I think this is a good thing to have (including a comment).
Otherwise someone could accidentally override the live version.

[0] https://github.com/dart-lang/dartlang.org/blob/master/src/appengine/app.yaml

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/app.yaml#n...
dart/site/try/app.yaml:51: - url: .*
Shouldn't this be "/.*" ?  [I don't think it can ever start without a slash].

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/build_try.gyp
File dart/site/try/build_try.gyp (right):

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/build_try....
dart/site/try/build_try.gyp:38: 'leap.dart',
This action should not only be executed if "leap.dart" changes, but also if the
dart2js compiler or the vm changed, right?

I'm not a gyp master, but sdk/bin/dart2js will eventually call the dart binary
in the build directory, so that should be listed as input here, right?

Maybe you can just depend on dart2js in the sdk in the built directory, and use
that also for compiling (instead of using sdk/bin/dart2js).

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/build_try....
dart/site/try/build_try.gyp:74: '<(SHARED_INTERMEDIATE_DIR)/sdk.json',
You could add a comment, that 'copies' will make implicit dependencies (i.e.
destination file depends on source file).

https://codereview.chromium.org/133893008/diff/60001/deps/all.deps/DEPS
File deps/all.deps/DEPS (right):

https://codereview.chromium.org/133893008/diff/60001/deps/all.deps/DEPS#newco...
deps/all.deps/DEPS:41: "font_awesome_rev": "@TBD",
Don't forget to change this one.

[ahe, 2014-01-15 14:09:38]

Thank you, Kasper and Martin!

https://codereview.chromium.org/133893008/diff/60001/dart/dart.gyp
File dart/dart.gyp (right):

https://codereview.chromium.org/133893008/diff/60001/dart/dart.gyp#newcode188
dart/dart.gyp:188: 'target_name': 'try',
On 2014/01/15 01:24:23, kustermann wrote:
> The name 'try' doesn't say much. Maybe we could rename that to 'try_dart' ?

I prefer keeping this name short as I have to type it on the command line.

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/app.yaml
File dart/site/try/app.yaml (right):

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/app.yaml#n...
dart/site/try/app.yaml:9: version: 7
On 2014/01/15 01:24:23, kustermann wrote:
> I think you should change "version: 7" to "version: CHANGEME" to make it
clear,
> that someone should change the version before using "appcfg.py" to upload a
new
> app. See, e.g. [0]: I think this is a good thing to have (including a
comment).
> Otherwise someone could accidentally override the live version.
> 
> [0]
https://github.com/dart-lang/dartlang.org/blob/master/src/appengine/app.yaml

I changed it to:

version: remember to edit app.yaml before deploying

This results in this error from appcfg.py:

Value 'please edit app.yaml' for version does not match expression
'^(?:^(?!-)[a-z\d\-]{0,62}[a-z\d]$)$'
  in ".../xcodebuild/ReleaseIA32/try_dartlang_org/app.yaml", line 8, column 10

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/app.yaml#n...
dart/site/try/app.yaml:21: # Soluion: Ignore its advice about "Leverage browser
caching".
On 2014/01/14 15:37:33, kasperl wrote:
> Soluion -> Solution.

Done.

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/app.yaml#n...
dart/site/try/app.yaml:51: - url: .*
On 2014/01/15 01:24:23, kustermann wrote:
> Shouldn't this be "/.*" ?  [I don't think it can ever start without a slash].

It works without the slash.

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/build_try.gyp
File dart/site/try/build_try.gyp (right):

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/build_try....
dart/site/try/build_try.gyp:1: # Copyright (c) 2013, the Dart project authors. 
Please see the AUTHORS file
On 2014/01/14 15:37:33, kasperl wrote:
> 2014

Done.

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/build_try....
dart/site/try/build_try.gyp:38: 'leap.dart',
On 2014/01/15 01:24:23, kustermann wrote:
> This action should not only be executed if "leap.dart" changes, but also if
the
> dart2js compiler or the vm changed, right?
> 
> I'm not a gyp master, but sdk/bin/dart2js will eventually call the dart binary
> in the build directory, so that should be listed as input here, right?
> 
> Maybe you can just depend on dart2js in the sdk in the built directory, and
use
> that also for compiling (instead of using sdk/bin/dart2js).

Yes. I forgot to add a dependency on the SDK build.

https://codereview.chromium.org/133893008/diff/60001/dart/site/try/build_try....
dart/site/try/build_try.gyp:74: '<(SHARED_INTERMEDIATE_DIR)/sdk.json',
On 2014/01/15 01:24:23, kustermann wrote:
> You could add a comment, that 'copies' will make implicit dependencies (i.e.
> destination file depends on source file).

Done.

https://codereview.chromium.org/133893008/diff/60001/deps/all.deps/DEPS
File deps/all.deps/DEPS (right):

https://codereview.chromium.org/133893008/diff/60001/deps/all.deps/DEPS#newco...
deps/all.deps/DEPS:41: "font_awesome_rev": "@TBD",
On 2014/01/15 01:24:23, kustermann wrote:
> Don't forget to change this one. 

Done.

[ahe, 2014-01-15 14:10:12]

Committed patchset #2 manually as r31828 (presubmit successful).