Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1338783002: Show import chains for unsupported dart:* library imports. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Show import chains for unsupported dart:* library imports. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/bae758fa6183744962ccf766ba442e7a9eb81c27

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 6

Patch Set 3 : Update cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -65 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 2 3 chunks +15 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 4 chunks +88 lines, -50 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 2 5 chunks +30 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/message_kind_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/missing_file_test.dart View 1 chunk +46 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 3 months ago (2015-09-11 15:29:26 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1338783002/diff/20001/pkg/compiler/lib/src/apiimpl.dart File pkg/compiler/lib/src/apiimpl.dart (right): https://codereview.chromium.org/1338783002/diff/20001/pkg/compiler/lib/src/apiimpl.dart#newcode350 pkg/compiler/lib/src/apiimpl.dart:350: if (libraryInfo == null) { It would be ...
5 years, 3 months ago (2015-09-14 12:34:58 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as bae758fa6183744962ccf766ba442e7a9eb81c27 (presubmit successful).
5 years, 3 months ago (2015-09-14 13:19:14 UTC) #4
Johnni Winther
5 years, 3 months ago (2015-09-14 13:23:39 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1338783002/diff/20001/pkg/compiler/lib/src/ap...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/1338783002/diff/20001/pkg/compiler/lib/src/ap...
pkg/compiler/lib/src/apiimpl.dart:350: if (libraryInfo == null) {
On 2015/09/14 12:34:57, sigurdm wrote:
> It would be nice to have another way than just returning null to signal what
> happened

Good point. Adding a TODO.

https://codereview.chromium.org/1338783002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1338783002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:779: /// Compute the set of distinct import
chains loading [uri] with
On 2015/09/14 12:34:57, sigurdm wrote:
>  /// Compute the set of distinct import chains to the library at [uri] within
> [loadedLibraries].
> 
> /// The chains are strings of the form ...

Done.

https://codereview.chromium.org/1338783002/diff/20001/pkg/compiler/lib/src/di...
File pkg/compiler/lib/src/diagnostics/messages.dart (right):

https://codereview.chromium.org/1338783002/diff/20001/pkg/compiler/lib/src/di...
pkg/compiler/lib/src/diagnostics/messages.dart:3297:
$DISALLOWED_LIBRARY_IMPORT_PADDING#{importChain}
On 2015/09/14 12:34:58, sigurdm wrote:
> Consider reformatting

Done.

Powered by Google App Engine
This is Rietveld 408576698