Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1338753004: Force disconnect all service clients when VM is shutting down (Closed)

Created:
5 years, 3 months ago by Cutch
Modified:
5 years, 3 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Force disconnect all service clients when VM is shutting down BUG=https://github.com/dart-lang/sdk/issues/24352 R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/ae57de89d1f4864ba8d14e80879178ea8172ad42

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M runtime/bin/vmservice/server.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/service/client.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 3 months ago (2015-09-15 17:18:32 UTC) #2
turnidge
lgtm w/ one minor. Curious: how did this come up? https://codereview.chromium.org/1338753004/diff/1/runtime/vm/service/client.dart File runtime/vm/service/client.dart (right): https://codereview.chromium.org/1338753004/diff/1/runtime/vm/service/client.dart#newcode17 ...
5 years, 3 months ago (2015-09-15 18:00:36 UTC) #3
Cutch
This came up when investigating this issue https://github.com/dart-lang/sdk/issues/24352 https://codereview.chromium.org/1338753004/diff/1/runtime/vm/service/client.dart File runtime/vm/service/client.dart (right): https://codereview.chromium.org/1338753004/diff/1/runtime/vm/service/client.dart#newcode17 runtime/vm/service/client.dart:17: On ...
5 years, 3 months ago (2015-09-15 19:46:45 UTC) #4
Cutch
5 years, 3 months ago (2015-09-15 19:47:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ae57de89d1f4864ba8d14e80879178ea8172ad42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698