Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 133843003: Merging all Angular tests into a single file (Closed)

Created:
6 years, 11 months ago by blois
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Merging all of the Angular tests into a single file to cut down on dart2js compile times. Using htmlIndividualConfig to cut down on how many tests are run at a time and to fail individual tests. Each individual test was taking ~28s locally to compile, now the entire combined test is taking about the same. This is still disabled overall as the dart2js compilation times are still timing out. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=31718

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+469 lines, -2867 lines) Patch
M pkg/pkg.status View 1 5 chunks +6 lines, -17 lines 0 comments Download
D pkg/third_party/angular_tests/_specs_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/_specs_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/angular_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/angular_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/bootstrap_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/bootstrap_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
A pkg/third_party/angular_tests/browser_test.dart View 1 1 chunk +304 lines, -0 lines 0 comments Download
A + pkg/third_party/angular_tests/browser_test.html View 3 chunks +2 lines, -3 lines 0 comments Download
D pkg/third_party/angular_tests/core/cache_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core/cache_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core/interpolate_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core/interpolate_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core/parser/generated_getter_setter_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core/parser/generated_getter_setter_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core/parser/lexer_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core/parser/lexer_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core/parser/parser_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core/parser/parser_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core/parser/static_parser_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core/parser/static_parser_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core/registry_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core/registry_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core/scope_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core/scope_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core/templateurl_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core/templateurl_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core/zone_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core/zone_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/block_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/block_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/compiler_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/compiler_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/cookies_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/cookies_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/directive_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/directive_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/http_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/http_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/ng_mustache_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/ng_mustache_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/node_cursor_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/node_cursor_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/selector_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/selector_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/shadow_root_options_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/core_dom/shadow_root_options_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/input_select_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/input_select_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_a_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_a_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_bind_html_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_bind_html_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_bind_template_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_bind_template_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_bind_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_bind_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_class_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_class_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_cloak_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_cloak_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_events_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_events_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_form_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_form_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_if_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_if_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_include_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_include_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_model_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_model_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_non_bindable_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_non_bindable_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_repeat_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_repeat_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_show_hide_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_show_hide_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_src_boolean_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_src_boolean_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_style_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_style_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_switch_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_switch_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_template_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/directive/ng_template_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/filter/currency_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/filter/currency_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/filter/date_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/filter/date_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/filter/filter_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/filter/filter_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/filter/json_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/filter/json_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/filter/limit_to_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/filter/limit_to_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/filter/lowercase_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/filter/lowercase_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/filter/number_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/filter/number_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/filter/order_by_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/filter/order_by_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/filter/uppercase_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/filter/uppercase_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/introspection_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/introspection_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/mock/http_backend_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/mock/http_backend_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/mock/test_bed_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/mock/test_bed_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/mock/zone_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/mock/zone_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/routing/ng_bind_route_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/routing/ng_bind_route_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/routing/ng_view_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/routing/ng_view_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/routing/routing_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/third_party/angular_tests/routing/routing_test.html View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/third_party/angular_tests/tools/html_extractor_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D pkg/third_party/angular_tests/tools/selector_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D pkg/third_party/angular_tests/tools/source_metadata_extractor_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
A pkg/third_party/angular_tests/vm_test.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/pkg/generate_angular_tests.sh View 1 1 chunk +127 lines, -0 lines 2 comments Download
M third_party/pkg/update_angular.sh View 1 chunk +1 line, -114 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
6 years, 11 months ago (2014-01-10 20:14:03 UTC) #1
Siggi Cherem (dart-lang)
lgtm, some minor suggestions below https://codereview.chromium.org/133843003/diff/40004/third_party/pkg/generate_angular_tests.sh File third_party/pkg/generate_angular_tests.sh (right): https://codereview.chromium.org/133843003/diff/40004/third_party/pkg/generate_angular_tests.sh#newcode28 third_party/pkg/generate_angular_tests.sh:28: cat << END_HEADER > ...
6 years, 11 months ago (2014-01-10 20:50:55 UTC) #2
blois
6 years, 11 months ago (2014-01-10 21:27:13 UTC) #3
blois
Committed patchset #2 manually as r31718 (presubmit successful).
6 years, 11 months ago (2014-01-10 22:54:53 UTC) #4
Siggi Cherem (dart-lang)
6 years, 11 months ago (2014-01-10 23:26:42 UTC) #5
Message was sent while issue was closed.
FYI - for a future change

https://codereview.chromium.org/133843003/diff/170001/third_party/pkg/generat...
File third_party/pkg/generate_angular_tests.sh (right):

https://codereview.chromium.org/133843003/diff/170001/third_party/pkg/generat...
third_party/pkg/generate_angular_tests.sh:28: echo "$(browser_header)" >
"${test_file}"
I think you can simplify this as:

   browser_header > $test_file

https://codereview.chromium.org/133843003/diff/170001/third_party/pkg/generat...
third_party/pkg/generate_angular_tests.sh:37: echo "$(browser_main)" >>
"${test_file}"
same here and below

Powered by Google App Engine
This is Rietveld 408576698