Issue 1338233002: Fix right shifting of a Mint value by an amount larger than 63.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1338233002: Fix right shifting of a Mint value by an amount larger than 63. (Closed)

Created:
5 years, 3 months ago by regis

Modified:
5 years, 3 months ago

Reviewers:
Mads Ager (google), hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix right shifting of a Mint value by an amount larger than 63. Add regression test. Enhance existing bit shift test. Fixes #24283 R=ager@google.com Committed: https://github.com/dart-lang/sdk/commit/e8139d4d9276da258ba4ee23b2796e9520172e29

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -1 line)			Patch
M	runtime/lib/integers.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/language/bit_shift_test.dart	View	2 chunks	+7 lines, -0 lines	0 comments	Download
A	tests/language/regress_24283_test.dart	View	1 chunk	+23 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

regis

On 2015/09/14 10:19:15, Mads Ager (google) wrote: > LGTM, thanks Regis! :) Thanks for finding ...

5 years, 3 months ago (2015-09-14 10:20:31 UTC) #4

regis

5 years, 3 months ago (2015-09-14 10:20:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e8139d4d9276da258ba4ee23b2796e9520172e29 (presubmit successful).