Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1337503003: Use the checked in SDK to build Observatory (Closed)

Created:
5 years, 3 months ago by Cutch
Modified:
5 years, 3 months ago
Reviewers:
ricow1, turnidge
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M runtime/observatory/observatory.gypi View 1 3 chunks +3 lines, -0 lines 0 comments Download
M tools/observatory_tool.py View 1 4 chunks +25 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Cutch
5 years, 3 months ago (2015-09-10 18:06:15 UTC) #2
Cutch
5 years, 3 months ago (2015-09-10 18:06:18 UTC) #3
turnidge
lgtm
5 years, 3 months ago (2015-09-10 18:08:16 UTC) #4
Cutch
Committed patchset #2 (id:20001) manually as e07d9e89183b400a1b3230e56b971da68a8e0bd7 (presubmit successful).
5 years, 3 months ago (2015-09-10 18:15:46 UTC) #5
ricow1
5 years, 3 months ago (2015-09-11 07:28:03 UTC) #7
Message was sent while issue was closed.
dbc, looks good, I have one suggesting to minimize issues in the future. Since
the old checked in binaries will be deprecated I think we should put the path
calculation for this into tools/utils.py so that all our tools use the same call
to get this

https://codereview.chromium.org/1337503003/diff/20001/tools/observatory_tool.py
File tools/observatory_tool.py (right):

https://codereview.chromium.org/1337503003/diff/20001/tools/observatory_tool....
tools/observatory_tool.py:30: def GetDartSdkPubExecutablePath():
how about moving this to tools/utils.py so that we have one (and only one way of
finding out about it) ?

Powered by Google App Engine
This is Rietveld 408576698