Issue 13375005: Implement subtype for type variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13375005: Implement subtype for type variables. (Closed)

Created:
7 years, 8 months ago by Johnni Winther

Modified:
7 years, 8 months ago

Reviewers:
karlklose, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Implement subtype for type variables. This implementation handles cyclicity in subtyping on type variables. Committed: https://code.google.com/p/dart/source/detail?r=21056

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+242 lines, -2 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View	1 2 3	1 chunk	+24 lines, -2 lines	0 comments	Download
	M	tests/compiler/dart2js/subtype_test.dart	View		2 chunks	+218 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Johnni Winther

On 2013/04/02 08:29:06, ahe wrote: > See my comments in https://codereview.chromium.org/13133006/ Fixed. PTAL

7 years, 8 months ago (2013-04-02 09:03:15 UTC) #4

Johnni Winther

7 years, 8 months ago (2013-04-08 10:30:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r21056 (presubmit successful).