Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1337143002: Add OCCURRENCES_CONTRIBUTOR_EXTENSION_POINT_ID. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -171 lines) Patch
D pkg/analysis_server/lib/analysis/navigation/navigation_core.dart View 1 chunk +0 lines, -40 lines 0 comments Download
A + pkg/analysis_server/lib/analysis/navigation_core.dart View 1 chunk +1 line, -1 line 1 comment Download
A pkg/analysis_server/lib/analysis/occurrences_core.dart View 1 chunk +35 lines, -0 lines 1 comment Download
M pkg/analysis_server/lib/plugin/navigation.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/plugin/occurrences.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/src/computer/computer_occurrences.dart View 1 chunk +0 lines, -78 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_server/lib/src/domains/analysis/occurrences.dart View 1 chunk +45 lines, -0 lines 1 comment Download
A pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart View 1 chunk +79 lines, -0 lines 1 comment Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 5 chunks +28 lines, -18 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 8 chunks +44 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/plugin/set_analysis_domain_test.dart View 7 chunks +52 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-11 19:36:06 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1337143002/diff/1/pkg/analysis_server/lib/analysis/navigation_core.dart File pkg/analysis_server/lib/analysis/navigation_core.dart (right): https://codereview.chromium.org/1337143002/diff/1/pkg/analysis_server/lib/analysis/navigation_core.dart#newcode5 pkg/analysis_server/lib/analysis/navigation_core.dart:5: library analysis_server.analysis.navigation_core; I would prefer to leave this ...
5 years, 3 months ago (2015-09-11 20:26:24 UTC) #2
scheglov
5 years, 3 months ago (2015-09-11 20:59:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef2fc0d778d21662e644db58d8cb6a8adf669099 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698