- Turn on writing of ic_data_array so that we have that information for script snapshots that would…

- Turn on writing of ic_data_array so that we have that information for script snapshots that would allow for code to be optimized right away

- Use snapshot Ids for singleton VM isolate singleton objects instead of writing them out into the snapshot

- Add support for writing function objects as an Id, this is needed to serialize function objects from the core library in a script snapshot (these function objects could potentially appear in the ICData).


BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/228e8f6edd371dfcfc18c45c06bb68ad1a717be0

[siva, 2015-09-14 22:36:12]

asiva@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-09-14 23:34:17]

https://codereview.chromium.org/1337083004/diff/1/runtime/vm/raw_object_snaps...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1337083004/diff/1/runtime/vm/raw_object_snaps...
runtime/vm/raw_object_snapshot.cc:658: if (func.usage_counter() == 0) {
Might as well clear it on the write-side to make the snapshot smaller.

[siva, 2015-09-15 21:40:04]

PTAL.

https://codereview.chromium.org/1337083004/diff/1/runtime/vm/raw_object_snaps...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1337083004/diff/1/runtime/vm/raw_object_snaps...
runtime/vm/raw_object_snapshot.cc:658: if (func.usage_counter() == 0) {
On 2015/09/14 23:34:17, rmacnak wrote:
> Might as well clear it on the write-side to make the snapshot smaller.

Done.

[rmacnak, 2015-09-15 23:17:29]

LGTM

https://codereview.chromium.org/1337083004/diff/20001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/1337083004/diff/20001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:1381: // Check it it is a double.
if it

https://codereview.chromium.org/1337083004/diff/20001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:2433: // ASSERT(!IsSingletonClassId(class_id) &&
!IsObjectStoreClassId(class_id));
Remove.

[siva, 2015-09-16 00:18:26]

Committed patchset #3 (id:40001) manually as
228e8f6edd371dfcfc18c45c06bb68ad1a717be0 (presubmit successful).

[siva, 2015-10-13 21:39:26]

https://codereview.chromium.org/1337083004/diff/20001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/1337083004/diff/20001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:1381: // Check it it is a double.
On 2015/09/15 23:17:29, rmacnak wrote:
> if it

Done.

https://codereview.chromium.org/1337083004/diff/20001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:2433: // ASSERT(!IsSingletonClassId(class_id) &&
!IsObjectStoreClassId(class_id));
On 2015/09/15 23:17:29, rmacnak wrote:
> Remove.

Done.