Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1336323003: Issue 24338. Don't propose creating a local class for prefixed identifiers. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 24338. Don't propose creating a local class for prefixed identifiers. Importing with prefix would take more time than I'd like to spend now. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cf88943a1049bdd4b3f6e44552a9c100bf9638a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -38 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 3 chunks +47 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-14 14:58:08 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-14 15:15:18 UTC) #2
scheglov
5 years, 3 months ago (2015-09-14 15:17:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cf88943a1049bdd4b3f6e44552a9c100bf9638a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698