Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1336303002: Avoid creating ConstructedConstantExpression for deferred constant. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid creating ConstructedConstantExpression for deferred constant. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/afc7f9acae73d51f46bd290898b685dd7a34aea7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
This fixes the assertion in host-checked mode.
5 years, 3 months ago (2015-09-14 12:23:37 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1336303002/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1336303002/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode3905 pkg/compiler/lib/src/resolution/members.dart:3905: isValidAsConstant = false; Explain why this is ok
5 years, 3 months ago (2015-09-14 12:36:43 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as afc7f9acae73d51f46bd290898b685dd7a34aea7 (presubmit successful).
5 years, 3 months ago (2015-09-14 13:28:34 UTC) #4
Johnni Winther
5 years, 3 months ago (2015-09-14 13:51:56 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1336303002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1336303002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3905: isValidAsConstant = false;
On 2015/09/14 12:36:43, sigurdm wrote:
> Explain why this is ok

Done.

Powered by Google App Engine
This is Rietveld 408576698