Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1335713003: Make base64 decoding return a Uint8List. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/crypto.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make base64 decoding return a Uint8List. This is more compact and more efficient if it ends up being sent between isolates. R=whesse@google.com Committed: https://github.com/dart-lang/crypto/commit/7ba83a20d7a15fb25a2eb23c1268cf36ce2b9c64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/base64.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
5 years, 3 months ago (2015-09-10 21:59:29 UTC) #2
Bill Hesse
lgtm We should do the .gitignore changes in all repositories.
5 years, 3 months ago (2015-09-10 22:10:05 UTC) #3
nweiz
5 years, 3 months ago (2015-09-10 23:10:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ba83a20d7a15fb25a2eb23c1268cf36ce2b9c64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698