dart2js cps: Remove code after calls that cannot return.

dart2js cps: Remove code after calls that cannot return.

This should resolve an outstanding issue with unreachable code being
transformed. A subterm in the unreachable code would get specialized
and then reanalyzed while some of the definitions in scope have no type.

This changes a lot of test case results. Some test results
have changed in very surprising ways, but I would argue
these are separate bugs that we should hunt down.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/19cb08fa050f765ccb67fd68f6e32b543a151d0b

[asgerf, 2015-09-15 13:31:04]

asgerf@google.com changed reviewers:
+ karlklose@google.com, kmillikin@google.com

[asgerf, 2015-09-15 13:31:05]

The status files includes the 4 lines that were currently red on master. We
could factor those out in a separate CL if we care about the history of status
files.

[Kevin Millikin (Google), 2015-09-15 13:50:10]

LGTM.

https://codereview.chromium.org/1335273003/diff/20001/tests/co19/co19-dart2js...
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/1335273003/diff/20001/tests/co19/co19-dart2js...
tests/co19/co19-dart2js.status:9581:
+Language/12_Expressions/28_Postfix_Expressions_A01_t05: Crash # Class
'PartialMethodElement' has no instance getter 'initializer'.
Karl has committed a fix for these two failures.

https://codereview.chromium.org/1335273003/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart (right):

https://codereview.chromium.org/1335273003/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart:15: foo() => ++x >
10;
Yuck.

[asgerf, 2015-09-15 14:06:40]

https://codereview.chromium.org/1335273003/diff/20001/tests/co19/co19-dart2js...
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/1335273003/diff/20001/tests/co19/co19-dart2js...
tests/co19/co19-dart2js.status:9581:
+Language/12_Expressions/28_Postfix_Expressions_A01_t05: Crash # Class
'PartialMethodElement' has no instance getter 'initializer'.
On 2015/09/15 13:50:10, Kevin Millikin (Google) wrote:
> Karl has committed a fix for these two failures.

Awesome!

https://codereview.chromium.org/1335273003/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart (right):

https://codereview.chromium.org/1335273003/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart:15: foo() => ++x >
10;
On 2015/09/15 13:50:10, Kevin Millikin (Google) wrote:
> Yuck.

I just don't want it to get constant folded or depend on Date or Math.

[asgerf, 2015-09-15 15:46:53]

Committed patchset #3 (id:40001) manually as
19cb08fa050f765ccb67fd68f6e32b543a151d0b (presubmit successful).